[Spice-devel] [PATCH spice 2/2] reds: Refactor agent message forwarding

[Christophe Fergeau]

On Mon, Sep 12, 2016 at 08:38:32AM -0400, Frediano Ziglio wrote:
> Don't we have an enum for this return instead of using int ?
> 
> enum {
>     AGENT_MSG_FILTER_OK,
>     AGENT_MSG_FILTER_DISCARD,
>     AGENT_MSG_FILTER_PROTO_ERROR,
>     AGENT_MSG_FILTER_MONITORS_CONFIG,
>     AGENT_MSG_FILTER_END
> };      
> 
> mumble... weird enum. Beside AGENT_MSG_FILTER_END which is
> not used there is OK but also a AGENT_MSG_FILTER_MONITORS_CONFIG
> which I suppose it's OK too... but this is not related to this
> patch.
> 

Fwiw, iirc AGENT_MSG_FILTER_MONITORS_CONFIG is used to switch between
having resolution changes managed by the guest agent (old-style), or
directly by QXL (new-style). Odd place to have that, but it's how this
was done.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160914/7582859c/attachment.sig>