[Spice-devel] [vdagent-linux v1 0/3] Reorganize vdagent Makefile and directory

Jonathon Jongsma jjongsma at redhat.com
Wed Sep 14 20:34:12 UTC 2016


On Wed, 2016-09-14 at 18:51 +0200, Victor Toso wrote:
> Hi,
> 
> Besides moving agents to their respective folders, some organization
> is
> done in the Makefile. I guess we could have Makefile to recursively
> build it later on.
> 
> I picked this three patches from vdagent-gtk branch from Marc-André
> at:
> https://github.com/elmarco/vdagent-gtk
> 
> I only changed the first patch to cover _LDADD and _CFLAGS variables
> too.
> 
> We might be interested in integrating/merging with other daemons such
> as
> spice-webdavd (in phodav) or the wip spice-ssh-agent from Fabiano [0]
> and for that reason I think that reorganizing the code a little bit
> is
> welcome.
> 
> [0] https://lists.freedesktop.org/archives/spice-devel/2016-September
> /031690.html
> 
> Cheers,
>   toso
> 
> Marc-André Lureau (2):
>   build-sys: get rid of noinst_HEADERS
>   build-sys: move user/system to respective dir
> 
> Victor Toso (1):
>   build-sys: reformat Makefile.am
> 
>  Makefile.am                              | 105 ++++++++++++++++++++-
> ----------
>  src/{ => vdagent}/vdagent-audio.c        |   0
>  src/{ => vdagent}/vdagent-audio.h        |   0
>  src/{ => vdagent}/vdagent-file-xfers.c   |   0
>  src/{ => vdagent}/vdagent-file-xfers.h   |   0
>  src/{ => vdagent}/vdagent-x11-priv.h     |   0
>  src/{ => vdagent}/vdagent-x11-randr.c    |   0
>  src/{ => vdagent}/vdagent-x11.c          |   0
>  src/{ => vdagent}/vdagent-x11.h          |   0
>  src/{ => vdagent}/vdagent.c              |   0
>  src/{ => vdagentd}/console-kit.c         |   0
>  src/{ => vdagentd}/dummy-session-info.c  |   0
>  src/{ => vdagentd}/session-info.h        |   0
>  src/{ => vdagentd}/systemd-login.c       |   0
>  src/{ => vdagentd}/vdagent-virtio-port.c |   0
>  src/{ => vdagentd}/vdagent-virtio-port.h |   0
>  src/{ => vdagentd}/vdagentd-uinput.c     |   0
>  src/{ => vdagentd}/vdagentd-uinput.h     |   0
>  src/{ => vdagentd}/vdagentd-xorg-conf.c  |   0
>  src/{ => vdagentd}/vdagentd-xorg-conf.h  |   0
>  src/{ => vdagentd}/vdagentd.c            |   0
>  21 files changed, 70 insertions(+), 35 deletions(-)
>  rename src/{ => vdagent}/vdagent-audio.c (100%)
>  rename src/{ => vdagent}/vdagent-audio.h (100%)
>  rename src/{ => vdagent}/vdagent-file-xfers.c (100%)
>  rename src/{ => vdagent}/vdagent-file-xfers.h (100%)
>  rename src/{ => vdagent}/vdagent-x11-priv.h (100%)
>  rename src/{ => vdagent}/vdagent-x11-randr.c (100%)
>  rename src/{ => vdagent}/vdagent-x11.c (100%)
>  rename src/{ => vdagent}/vdagent-x11.h (100%)
>  rename src/{ => vdagent}/vdagent.c (100%)
>  rename src/{ => vdagentd}/console-kit.c (100%)
>  rename src/{ => vdagentd}/dummy-session-info.c (100%)
>  rename src/{ => vdagentd}/session-info.h (100%)
>  rename src/{ => vdagentd}/systemd-login.c (100%)
>  rename src/{ => vdagentd}/vdagent-virtio-port.c (100%)
>  rename src/{ => vdagentd}/vdagent-virtio-port.h (100%)
>  rename src/{ => vdagentd}/vdagentd-uinput.c (100%)
>  rename src/{ => vdagentd}/vdagentd-uinput.h (100%)
>  rename src/{ => vdagentd}/vdagentd-xorg-conf.c (100%)
>  rename src/{ => vdagentd}/vdagentd-xorg-conf.h (100%)
>  rename src/{ => vdagentd}/vdagentd.c (100%)
> 
> --
> 2.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel



ACK from me, unless somebody else has objections about the file moves.

Jonathon


More information about the Spice-devel mailing list