[Spice-devel] [vdagent-linux v2 0/5] Reorganize vdagent Makefile and directory

Jonathon Jongsma jjongsma at redhat.com
Thu Sep 15 20:08:52 UTC 2016


Series looks good to me.

Jonathon


On Thu, 2016-09-15 at 18:51 +0200, Victor Toso wrote:
> Hi, second version.
> 
> In the first patch, I've added the $(NULL), diff is here:
> http://paste.fedoraproject.org/428487/73955986/
> 
> We now have a 4th patch that we might want to merge with the 3rd
> patch... Having
> an extra patch helps with the review, I guess.
> 
> The 5th patch is a small typo that I've just found.
> 
> Keeping the acks from Jonathon and Frediano in the first three
> patches.
> 
> Cheers,
>   toso
> 
> Marc-André Lureau (2):
>   build-sys: get rid of noinst_HEADERS
>   build-sys: move user/system to respective dir
> 
> Victor Toso (3):
>   build-sys: reformat Makefile.am
>   build-sys: remove prefix from filenames
>   buildsys: statis typo in configure option
> 
>  .gitignore                                         |   6 ++
>  Makefile.am                                        | 109
> ++++++++++++++-------
>  configure.ac                                       |   2 +-
>  src/{vdagent-audio.c => vdagent/audio.c}           |   2 +-
>  src/{vdagent-audio.h => vdagent/audio.h}           |   4 +-
>  src/{vdagent-file-xfers.c => vdagent/file-xfers.c} |   4 +-
>  src/{vdagent-file-xfers.h => vdagent/file-xfers.h} |   0
>  src/{ => vdagent}/vdagent.c                        |   6 +-
>  src/{vdagent-x11-priv.h => vdagent/x11-priv.h}     |   0
>  src/{vdagent-x11-randr.c => vdagent/x11-randr.c}   |   4 +-
>  src/{vdagent-x11.c => vdagent/x11.c}               |   4 +-
>  src/{vdagent-x11.h => vdagent/x11.h}               |   4 +-
>  src/{ => vdagentd}/console-kit.c                   |   0
>  src/{ => vdagentd}/dummy-session-info.c            |   0
>  src/{ => vdagentd}/session-info.h                  |   0
>  src/{ => vdagentd}/systemd-login.c                 |   0
>  src/{vdagentd-uinput.c => vdagentd/uinput.c}       |   4 +-
>  src/{vdagentd-uinput.h => vdagentd/uinput.h}       |   0
>  src/{ => vdagentd}/vdagentd.c                      |   6 +-
>  .../virtio-port.c}                                 |   2 +-
>  .../virtio-port.h}                                 |   4 +-
>  src/{vdagentd-xorg-conf.c => vdagentd/xorg-conf.c} |   2 +-
>  src/{vdagentd-xorg-conf.h => vdagentd/xorg-conf.h} |   0
>  23 files changed, 104 insertions(+), 59 deletions(-)
>  rename src/{vdagent-audio.c => vdagent/audio.c} (99%)
>  rename src/{vdagent-audio.h => vdagent/audio.h} (91%)
>  rename src/{vdagent-file-xfers.c => vdagent/file-xfers.c} (99%)
>  rename src/{vdagent-file-xfers.h => vdagent/file-xfers.h} (100%)
>  rename src/{ => vdagent}/vdagent.c (99%)
>  rename src/{vdagent-x11-priv.h => vdagent/x11-priv.h} (100%)
>  rename src/{vdagent-x11-randr.c => vdagent/x11-randr.c} (99%)
>  rename src/{vdagent-x11.c => vdagent/x11.c} (99%)
>  rename src/{vdagent-x11.h => vdagent/x11.h} (95%)
>  rename src/{ => vdagentd}/console-kit.c (100%)
>  rename src/{ => vdagentd}/dummy-session-info.c (100%)
>  rename src/{ => vdagentd}/session-info.h (100%)
>  rename src/{ => vdagentd}/systemd-login.c (100%)
>  rename src/{vdagentd-uinput.c => vdagentd/uinput.c} (99%)
>  rename src/{vdagentd-uinput.h => vdagentd/uinput.h} (100%)
>  rename src/{ => vdagentd}/vdagentd.c (99%)
>  rename src/{vdagent-virtio-port.c => vdagentd/virtio-port.c} (99%)
>  rename src/{vdagent-virtio-port.h => vdagentd/virtio-port.h} (97%)
>  rename src/{vdagentd-xorg-conf.c => vdagentd/xorg-conf.c} (99%)
>  rename src/{vdagentd-xorg-conf.h => vdagentd/xorg-conf.h} (100%)
> 


More information about the Spice-devel mailing list