[Spice-devel] [PATCH v2 2/2] Add DisplayChannelPrivate struct

Frediano Ziglio fziglio at redhat.com
Fri Sep 16 09:31:34 UTC 2016


> 
> On Thu, 2016-09-15 at 15:06 -0500, Jonathon Jongsma wrote:
> > On Thu, 2016-09-15 at 11:22 -0500, Jonathon Jongsma wrote:
> > > Move all of the DisplayChannel data memembers into a private
> > > struct
...

> > > @@ -783,11 +787,13 @@ static void handle_dev_oom(void *opaque,
> > > void
> > > *payload)
> > >          display_channel_free_some(worker->display_channel);
> > >          red_qxl_flush_resources(worker->qxl);
> > >      }
> > > +#if FIXME
> > >      spice_debug("OOM2 #draw=%u, #glz_draw=%u current %u pipes
> > > %u",
> > >                  display->drawable_count,
> > >                  display->encoder_shared_data.glz_drawable_count,
> > >                  display->current_size,
> > >                  red_channel_sum_pipes_size(display_red_channel));
> > > +#endif
> 
> I am ok to remove these debugs, do you have an idea how to fix them
> 

I would add a display_channel_debug_oom function.
I'll try to send some fixup.

Frediano


More information about the Spice-devel mailing list