[Spice-devel] [PATCH v2 5/8] replay: Remove useless check

[Pavel Grunt]

On Thu, 2016-09-15 at 23:19 +0100, Frediano Ziglio wrote:
> Same check is done inside replay_fscanf

But removing it will not prevent calling red_replay_compat_drawable or
red_replay_native_drawable

Maybe you want to check the return value of replay_fscanf

Pavel

> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/red-replay-qxl.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index 28da13d..ef5569e 100644
> --- a/server/red-replay-qxl.c
> +++ b/server/red-replay-qxl.c
> @@ -1063,9 +1063,6 @@ static QXLCompatDrawable
> *red_replay_compat_drawable(SpiceReplay *replay, uint32
>  
>  static QXLPHYSICAL red_replay_drawable(SpiceReplay *replay,
> uint32_t flags)
>  {
> -    if (replay->error) {
> -        return 0;
> -    }
>      replay_fscanf(replay, "drawable\n");
>      if (flags & QXL_COMMAND_FLAG_COMPAT) {
>          return
> QXLPHYSICAL_FROM_PTR(red_replay_compat_drawable(replay, flags));
>