[Spice-devel] [RFC PATCH 0/2] Reintroduce some macro to iterate containers

Uri Lublin uril at redhat.com
Mon Sep 19 15:10:53 UTC 2016


On 09/16/2016 06:06 PM, Frediano Ziglio wrote:
> With the introduction of GList/GQueue these macro were removed
> at the expense of some minor regressions.
> The first patch was started time ago and resemble more to old
> macro while the second try to use some more safe way.
>
> Frediano Ziglio (2):
>   RedChannel: Add FOREACH_CHANNEL and use it to iterate
>   Introduce some macro to simplify iteration on GList
>
>  server/red-channel.c  | 50 ++++++++++++++++++--------------------
>  server/red-common.h   | 18 ++++++++++++++
>  server/reds-private.h |  3 +++
>  server/reds.c         | 66 +++++++++++++++++++++++++--------------------------
>  4 files changed, 76 insertions(+), 61 deletions(-)
>

Looks good. See some comments in separate patches.
Can you swap the order of those patches and
define FOREACH_CHANNEL based on GLIST_FOREACH ?



More information about the Spice-devel mailing list