[Spice-devel] [PATCH v2 0/6] Reintroduce some macro to iterate containers

Jonathon Jongsma jjongsma at redhat.com
Tue Sep 20 12:32:55 UTC 2016


On Tue, 2016-09-20 at 09:04 +0100, Frediano Ziglio wrote:
> With the introduction of GList/GQueue these macro were removed
> at the expense of some minor regressions.
> First patch introduce macros for iterating generic Glist,
> others use them.
> 
> Frediano Ziglio (6):
>   Introduce some macros to simplify iteration on GList
>   RedChannel: Add FOREACH_CHANNEL and use it to iterate
>   RedChannel: Use more FOREACH_CLIENT macro
>   Use proper FOREACH_DCC instead of FOREACH_CLIENT
>   Base FOREACH_CLIENT on GLIST_FOREACH
>   Base FOREACH_DCC on GLIST_FOREACH
> 
>  server/display-channel.c | 42 ++++++++++++-------------
>  server/display-channel.h | 11 ++-----
>  server/main-channel.c    | 20 ++++++------
>  server/red-channel.c     | 80 ++++++++++++++++++++++--------------
> ------------
>  server/red-channel.h     | 12 ++------
>  server/red-common.h      | 18 +++++++++++
>  server/red-worker.c      |  8 ++---
>  server/reds-private.h    |  3 ++
>  server/reds.c            | 66 +++++++++++++++++++-------------------
> -
>  server/stream.c          | 24 +++++++--------
>  10 files changed, 142 insertions(+), 142 deletions(-)
> 


Aside from the naming issue mentioned in patch 2/6, the series looks OK
to me.

Jonathon


More information about the Spice-devel mailing list