[Spice-devel] [PATCH 7/8] Remove unused fields

Jonathon Jongsma jjongsma at redhat.com
Thu Sep 22 08:13:29 UTC 2016


I'd like to add a comment to the commit log explaining some of the
history. It looks like these fields were added in
a32e90257e834e340075e633132b52c612be4578 as part of the multiple client
support and were never used. 


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>



On Mon, 2016-09-19 at 09:30 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/display-channel.h | 2 --
>  server/red-worker.h      | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/server/display-channel.h b/server/display-channel.h
> index 7b71480..cf4135d 100644
> --- a/server/display-channel.h
> +++ b/server/display-channel.h
> @@ -55,8 +55,6 @@ struct Drawable {
>      RingItem list_link;
>      DrawItem tree_item;
>      Ring pipes;
> -    RedPipeItem *pipe_item_rest;
> -    uint32_t size_pipe_item_rest;
>      RedDrawable *red_drawable;
>  
>      GlzImageRetention glz_retention;
> diff --git a/server/red-worker.h b/server/red-worker.h
> index a0a327a..7d68678 100644
> --- a/server/red-worker.h
> +++ b/server/red-worker.h
> @@ -35,7 +35,6 @@ typedef struct CommonGraphicsChannel {
>  
>      QXLInstance *qxl;
>      uint8_t recv_buf[CHANNEL_RECEIVE_BUF_SIZE];
> -    uint32_t id_alloc; // bitfield. TODO - use this instead of shift
> scheme.
>      int during_target_migrate; /* TRUE when the client that is
> associated with the channel
>                                    is during migration. Turned off
> when the vm is started.
>                                    The flag is used to avoid sending
> messages that are artifacts


More information about the Spice-devel mailing list