[Spice-devel] [PATCH qxl-wddm-dod v5 2/7] Code Analysis fix

[Christophe Fergeau]

On Tue, Sep 27, 2016 at 01:01:22PM +0300, Dmitry Fleytman wrote:
> 
> > On 27 Sep 2016, at 12:35 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > 
> > Hey,
> > 
> > A huge part of this patch is adding +__declspec(code_seg("PAGE"))  (and
> > removing #pragma code_seg()), which are probably related to this macro,
> > but which are added with no rationale.
> > The shortlog should probably be something different than "code analysis
> > fix", but more somethnig like "Use PAGED_CODE() at the beginning of each
> > pageable method".
> > Is it possible/desirable to prevent these methods from ending in
> > pageable memory?
> 
> Hi Christophe,
> 
> #pragma code_seg() and __declspec(codes()) are interchangeable,
> in this specific case __declspec is more convenient.

Isn't this something we want for mostly the whole file? Anyway, I'd
split this part to a different commit.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160927/57e503bb/attachment.sig>