[Spice-devel] [PATCH 11/18] Use mnemonic returning invalid value

Christophe Fergeau cfergeau at redhat.com
Tue Sep 27 12:19:55 UTC 2016


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

though I'd use enum value, named constant, ... in the log rather than
mnemonic.


On Mon, Sep 26, 2016 at 09:12:44AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/spice-bitmap-utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/spice-bitmap-utils.c b/server/spice-bitmap-utils.c
> index a423ad9..72a9285 100644
> --- a/server/spice-bitmap-utils.c
> +++ b/server/spice-bitmap-utils.c
> @@ -132,7 +132,7 @@ int spice_bitmap_from_surface_type(uint32_t surface_format)
>      default:
>          spice_critical("Unsupported surface format");
>      }
> -    return 0;
> +    return SPICE_BITMAP_FMT_INVALID;
>  }
>  
>  #ifdef DUMP_BITMAP
> -- 
> 2.7.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160927/7266c76a/attachment.sig>


More information about the Spice-devel mailing list