[Spice-devel] [PATCH 08/18] Add a comment for marshaller field

Frediano Ziglio fziglio at redhat.com
Tue Sep 27 12:31:26 UTC 2016


> 
> On Mon, Sep 26, 2016 at 09:12:41AM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/red-channel-client-private.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/server/red-channel-client-private.h
> > b/server/red-channel-client-private.h
> > index 46d4fca..804b39a 100644
> > --- a/server/red-channel-client-private.h
> > +++ b/server/red-channel-client-private.h
> > @@ -38,6 +38,7 @@ struct RedChannelClientPrivate
> >      } ack_data;
> >  
> >      struct {
> > +        /* this can be either main.marshaller or urgent.marshaller */
> 
> If this can also be NULL, I'd mention it explicitly.
> 
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Christophe
> 

Mumble... no, cannot be NULL, actually marshaller are initialized during
construction and freed on destruction.

Frediano


More information about the Spice-devel mailing list