[Spice-devel] [PATCH 03/18] Add small comment for detach_stream

[Frediano Ziglio]

> 
> On Mon, Sep 26, 2016 at 09:12:36AM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/stream.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/server/stream.c b/server/stream.c
> > index 9d878c8..95ff015 100644
> > --- a/server/stream.c
> > +++ b/server/stream.c
> > @@ -320,6 +320,9 @@ static void attach_stream(DisplayChannel *display,
> > Drawable *drawable, Stream *s
> >      }
> >  }
> >  
> > +/**
> > + * Detach drawable from the stream.
> > + */
> >  void detach_stream(DisplayChannel *display, Stream *stream)
> 
> This does not make what the function does a lot more explicit to me ;)
> Wouldn't it be better to rename the function instead?
> detach_drawable_from_stream() still seems (nearly) acceptable from a
> length point of view?
> 
> Christophe
> 

What about stream_detach_drawable ?
And actually... the display parameter is not used...
I'll send an update patch.

Frediano