[Spice-devel] [PATCH qxl-wddm-dod v6 3/4] Code Analysis and style fix

[Frediano Ziglio]

> 
> Based on a patch by Sandy Stutsman <sstutsma at redhat.com>
> 
> Signed-off-by: Sameeh Jubran <sameeh at daynix.com>

Acked-by: Frediano Ziglio <fziglio at redhat.com>

> ---
>  qxldod/QxlDod.cpp | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index 2bc6b77..577b4ff 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -1493,7 +1493,7 @@ NTSTATUS QxlDod::CommitVidPn(_In_ CONST
> DXGKARG_COMMITVIDPN* CONST pCommitVidPn)
>  
>  CommitVidPnExit:
>  
> -    NTSTATUS TempStatus;
> +    NTSTATUS TempStatus(STATUS_SUCCESS);
>      UNREFERENCED_PARAMETER(TempStatus);
>  
>      if ((pVidPnSourceModeSetInterface != NULL) &&
> @@ -1851,7 +1851,7 @@ NTSTATUS QxlDod::WriteHWInfoStr(_In_ HANDLE
> DevInstRegKeyHandle, _In_ PCWSTR psz
>  }
>  
>  QXL_PAGED
> -NTSTATUS QxlDod::RegisterHWInfo(ULONG Id)
> +NTSTATUS QxlDod::RegisterHWInfo(_In_ ULONG Id)
>  {
>      PAGED_CODE();
>  
> @@ -3247,7 +3247,7 @@ NTSTATUS QxlDevice::GetCurrentMode(ULONG* pMode)
>  }
>  
>  QXL_PAGED
> -NTSTATUS QxlDevice::SetPowerState(_In_ DEVICE_POWER_STATE DevicePowerState,
> DXGK_DISPLAY_INFORMATION* pDispInfo)
> +NTSTATUS QxlDevice::SetPowerState(DEVICE_POWER_STATE DevicePowerState,
> DXGK_DISPLAY_INFORMATION* pDispInfo)
>  {
>      PAGED_CODE();
>      DbgPrint(TRACE_LEVEL_VERBOSE, ("---> %s\n", __FUNCTION__));

After merging I realize that in a previous patch the same change
was done for VgaDevice::SetPowerState.
Was this removal intentional or a mistake?

Frediano