[Spice-devel] [PATCH qxl-wddm-dod v6 2/4] Using declspec instead of #pragma to declare pageable functions

[Frediano Ziglio]

> 
> On Wed, Sep 28, 2016 at 02:09:26PM +0300, Sameeh Jubran wrote:
> > This patch replaces the "#pragma code_seg(push)" and "#pragma
> > code_seg(pop)"
> > with __declspec(code_seg("PAGE")) for declaring code as pageable. This
> > change enahnces maintainability as it is much clearer which functions are
> > paged.
> 
> s/enahnces/enhances/
> 
> 1/4 already adds PAGED_CODE at the beginning of each paged functions, do
> we really need to add a second reminder to each function? This also
> adds it 2 times, once in the .h file and once in the .cpp file for more
> redundancy. Imo the current way it's done is enough (unless some
> functions which should be marked as pageable aren't).
> 
> If you want something explicit, what could be done instead is to
> explicitly mark the non-pageable functions so that these ones too can be
> seen at once, rather than having to look for what is missing from these
> functions declarations/definitions.
> 
> 
> Christophe
> 

Going to propose another style patch.

Frediano