[Spice-devel] [PATCH spice-space-pages 1/5] multiple-monitors: Move caveat to the end of the document

[Frediano Ziglio]

> On Fri, 2017-03-31 at 13:15 -0400, Frediano Ziglio wrote:
> > > 
> > > Although limited multimonitor functionality will work without a
> > > vdagent
> > > and qxl driver, we should emphasize using the appropriate
> > > components. So
> > > move the caveat to a separate notes section at the end of the
> > > document.
> > > ---
> > >  multiple-monitors.rst | 24 ++++++++++++++----------
> > >  1 file changed, 14 insertions(+), 10 deletions(-)
> > > 
> > > diff --git a/multiple-monitors.rst b/multiple-monitors.rst
> > > index dd7a439..b90fb9e 100644
> > > --- a/multiple-monitors.rst
> > > +++ b/multiple-monitors.rst
> > > @@ -10,16 +10,6 @@ Guest requirements
> > >  ++++++++++++++++++
> > >  Both Windows and Linux guests should be configured with a QXL
> > > video device
> > >  and
> > >  a spice vdagent to take full advantage of the multiple monitor
> > >  functionality.
> > > -While these are not absolutely required, they are highly
> > > recommended.
> > > -
> > > -Without a spice vdagent running in the guest, it may be possible
> > > to enable
> > > or
> > > -disable displays from within the guest (and the spice client will
> > > adapt to
> > > -those changes), but it will not be possible to enable or disable
> > > displays
> > > from
> > > -the client.
> > > -
> > > -Without a QXL driver in the guest, it may be possible to resize a
> > > display,
> > > but
> > > -it will not be possible to resize it to an arbitrary resolution.
> > > Each
> > > display
> > > -will only support a fixed set of resolutions.
> > >  
> > >  Guest QXL Configuration
> > >  +++++++++++++++++++++++
> > > @@ -203,3 +193,17 @@ client monitors. For example, if you have 3
> > > monitors and
> > > want to run
> > >  virt-viewer in fullscreen mode on the last two, you can use
> > >  `monitor-mapping=1:2;2:3`. That will place guest display 1 on
> > > client monitor
> > >  2,
> > >  and guest display 2 on client monitor 3.
> > > +
> > > +Additional Notes
> > > +++++++++++++++++
> > > +While a vdagent and QXL driver are not absolutely required, they
> > > are highly
> > > +recommended.
> > > +
> > > +Without a spice vdagent running in the guest, it may be possible
> > > to enable
> > > or
> > > +disable displays from within the guest (and the spice client will
> > > adapt to
> > > +those changes), but it will not be possible to enable or disable
> > > displays
> > > from
> > > +the client.
> > > +
> > > +Without a QXL driver in the guest, it may be possible to resize a
> > > display,
> > > but
> > > +it will not be possible to resize it to an arbitrary resolution.
> > > Each
> > > display
> > > +will only support a fixed set of resolutions.
> > 
> > The series is fine for me.
> > 
> > Acked
> > 
> 
> 
> So, did you have any concern about the low (8MB) allocation I
> recommended for KMS/rhel7? I know it is not actually possible to
> allocate that little at the moment due to qemu restrictions. But I did
> not do extensive testing to see how much is needed there. That bar is
> still used for some things (cursors, images, commands?). It would be
> nice if we could get some data on how full that memory gets under
> normal use...
> 
> Jonathon
> 

I didn't remember who filled the document with memory layout so I tried
to have a quick view at kernel driver sources.
It's confusing as it refers to Bar0 as VRAM (while in Qemu vram refers
to Bar1) and to Bar1 as surface memory.
As surfaces are not used yes, 8mb is fine.

Frediano