[Spice-devel] [PATCH 5/7] Remove unused red_channel_test_remote_common_cap()

Jonathon Jongsma jjongsma at redhat.com
Fri Apr 7 15:23:59 UTC 2017


This was a convenience function around
red_channel_client_test_remote_common_cap() that simply iterated over
each client (currently we only really support a single client anyway)
and returned TRUE only if all clients supported the capability. But
nobody ever called this wrapper function.
---
 server/red-channel.c | 13 -------------
 server/red-channel.h |  1 -
 2 files changed, 14 deletions(-)

diff --git a/server/red-channel.c b/server/red-channel.c
index 2163066..9bd9823 100644
--- a/server/red-channel.c
+++ b/server/red-channel.c
@@ -314,19 +314,6 @@ void red_channel_add_client(RedChannel *channel, RedChannelClient *rcc)
     channel->priv->clients = g_list_prepend(channel->priv->clients, rcc);
 }
 
-bool red_channel_test_remote_common_cap(RedChannel *channel, uint32_t cap)
-{
-    GListIter iter;
-    RedChannelClient *rcc;
-
-    FOREACH_CLIENT(channel, iter, rcc) {
-        if (!red_channel_client_test_remote_common_cap(rcc, cap)) {
-            return FALSE;
-        }
-    }
-    return TRUE;
-}
-
 bool red_channel_test_remote_cap(RedChannel *channel, uint32_t cap)
 {
     GListIter iter;
diff --git a/server/red-channel.h b/server/red-channel.h
index cc11639..a9088a7 100644
--- a/server/red-channel.h
+++ b/server/red-channel.h
@@ -157,7 +157,6 @@ bool red_channel_is_waiting_for_migrate_data(RedChannel *channel);
 void red_channel_destroy(RedChannel *channel);
 
 /* return true if all the channel clients support the cap */
-bool red_channel_test_remote_common_cap(RedChannel *channel, uint32_t cap);
 bool red_channel_test_remote_cap(RedChannel *channel, uint32_t cap);
 
 /* should be called when a new channel is ready to send messages */
-- 
2.9.3



More information about the Spice-devel mailing list