[Spice-devel] [spice-gtk] usb-device-manager: Do not hide devices on client if USB redirection disabled

Christophe Fergeau cfergeau at redhat.com
Mon Apr 10 08:36:47 UTC 2017


On Sun, Apr 09, 2017 at 06:16:45PM +0300, Yuri Benditovich wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1431137
> When auto sharing of USB devices is enabled in remote-viewer's configuration
> file, Windows spice client hides connected USB devices on client machine even
> if USB redirection is disabled by --spice-disable-usbredir.
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich at daynix.com>
> ---
>  src/usb-device-manager.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
> index 4d0b93d..fc17338 100644
> --- a/src/usb-device-manager.c
> +++ b/src/usb-device-manager.c
> @@ -1945,6 +1945,12 @@ void _usbdk_hider_update(SpiceUsbDeviceManager *manager)
>          return;
>      }
>  
> +    if (!spice_session_get_usbredir_enabled(priv->session)) {
> +        SPICE_DEBUG("Usb redirection is disabled, no hider setup needed");

"USB redirection disabled, ..."

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

with this change.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170410/4f1c0556/attachment.sig>


More information about the Spice-devel mailing list