[Spice-devel] [spice-gtk v2] usb-device-manager: Do not hide devices on client if USB redirection disabled

[Christophe Fergeau]

On Tue, Apr 11, 2017 at 11:43:03AM +0300, Yuri Benditovich wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1431137
> When auto sharing of USB devices is enabled in remote-viewer's configuration
> file, Windows spice client hides connected USB devices on client machine even
> if USB redirection is disabled by --spice-disable-usbredir.
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich at daynix.com>

Acked-by: Christophe Fergeau <cfergeau at redhat.com>
(I'm assuming you can push this yourself?)



> ---
>  src/usb-device-manager.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
> index 4d0b93d..6e6a683 100644
> --- a/src/usb-device-manager.c
> +++ b/src/usb-device-manager.c
> @@ -1945,6 +1945,12 @@ void _usbdk_hider_update(SpiceUsbDeviceManager *manager)
>          return;
>      }
>  
> +    if (!spice_session_get_usbredir_enabled(priv->session)) {
> +        SPICE_DEBUG("USB redirection disabled, no hider setup needed");
> +        _usbdk_hider_clear(manager);
> +        return;
> +    }
> +
>      if (!priv->auto_connect) {
>          SPICE_DEBUG("Auto-connect disabled, no hider setup needed");
>          _usbdk_hider_clear(manager);
> -- 
> 2.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170411/a4fdb509/attachment.sig>