[Spice-devel] [spice-server 1/3] Remove unneeded rcc->priv->latency_monitor.timer checks

[Christophe Fergeau]

On Tue, Apr 11, 2017 at 08:54:15AM -0400, Frediano Ziglio wrote:
> > 
> > red_channel_client_start_ping_timer(),
> > red_channel_client_cancel_ping_timer(),
> > red_channel_client_restart_ping_timer() are no-ops when
> > rcc->priv->latency_monitor.timer is NULL, so there is no need to
> > explicitly check it's not NULL before calling these functions.
> > 
> > Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Looking at code it seems the check is moved, not removed.

I've changed the commit log to:

    Remove unneeded rcc->priv->latency_monitor.timer checks

    Beforoe this commit, red_channel_client_start_ping_timer() and
    red_channel_client_cancel_ping_timer() had checks to be no-ops when
    rcc->priv->latency_monitor.timer is NULL.

    This commit adds a similar check to
    red_channel_client_restart_ping_timer(), and removes explicit NULL
    checks before calls to red_channel_client_{cancel,restart,start}_ping_timer()

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170411/30a560ea/attachment.sig>