[Spice-devel] [spice-gtk v1] file-xfer: Fix bad filename encoding

Victor Toso victortoso at redhat.com
Wed Apr 12 10:35:11 UTC 2017

From: Victor Toso <me at victortoso.com>

 > The name is the on-disk filename which may not be in any known
 > encoding, and can thus not be generally displayed as is.

Considering a file named "ěščřžýáíé", if we use
G_FILE_ATTRIBUTE_STANDARD_NAME get the file name, we will have the
following 72 char long string:

We should be use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME instead which
will give us the correct 18 long utf-8 string: "ěščřžýáíé"

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1440206

Signed-off-by: Victor Toso <victortoso at redhat.com>
 src/channel-main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/channel-main.c b/src/channel-main.c
index be7c852..c8de5f3 100644
--- a/src/channel-main.c
+++ b/src/channel-main.c
@@ -2846,7 +2846,7 @@ static void file_xfer_init_task_async_cb(GObject *obj, GAsyncResult *res, gpoint
         goto failed;
     channel = spice_file_transfer_task_get_channel(xfer_task);
-    basename = g_file_info_get_attribute_as_string(info, G_FILE_ATTRIBUTE_STANDARD_NAME);
+    basename = g_file_info_get_attribute_as_string(info, G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME);
     file_size = g_file_info_get_attribute_uint64(info, G_FILE_ATTRIBUTE_STANDARD_SIZE);
     xfer_op = data;

More information about the Spice-devel mailing list