[Spice-devel] [PATCH qxl-wddm-dod 05/12] Remove generation field from MemSlot
Pavel Grunt
pgrunt at redhat.com
Wed Apr 12 13:55:56 UTC 2017
On Wed, 2017-04-12 at 14:19 +0100, Frediano Ziglio wrote:
> Not used beside during initialization of MemSlot itself
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
> ---
> qxldod/QxlDod.cpp | 3 +--
> qxldod/QxlDod.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index 0c2c9c5..c575f0d 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -3700,9 +3700,8 @@ void QxlDevice::SetupMemSlot(UINT8 Idx, UINT64
> pastart, UINT64 paend, UINT8 *vas
>
> SetupHWSlot(Idx + 1, pSlot);
>
> - pSlot->generation = m_RomHdr->slot_generation;
> high_bits = slot_index << m_SlotGenBits;
> - high_bits |= pSlot->generation;
> + high_bits |= m_RomHdr->slot_generation;
> high_bits <<= (64 - (m_SlotGenBits + m_SlotIdBits));
> pSlot->high_bits = high_bits;
> DbgPrint(TRACE_LEVEL_VERBOSE, ("<--- %s\n", __FUNCTION__));
> diff --git a/qxldod/QxlDod.h b/qxldod/QxlDod.h
> index 6308ab1..9cb120d 100755
> --- a/qxldod/QxlDod.h
> +++ b/qxldod/QxlDod.h
> @@ -361,7 +361,6 @@ private:
> };
>
> typedef struct _MemSlot {
> - UINT8 generation;
> UINT64 start_phys_addr;
> UINT64 end_phys_addr;
> UINT8 *start_virt_addr;
More information about the Spice-devel
mailing list