[Spice-devel] [PATCH v2 0/6] sound cleanups

[Pavel Grunt]

Hi Jonathon,

I don't see a benefit of removing ("inlining") on_new_{playback,
record}_channel_client. I actually prefer shorter functions even if it
means that some other function is called only once. It is also
recommended in the style document:
https://www.spice-space.org/spice-project-coding-style-and-coding-conv
entions.html#_short_functions

In case you do it to make more obvious that the client is not active
then imho is better to assert it.

Pavel

On Mon, 2017-04-24 at 12:09 -0500, Jonathon Jongsma wrote:
> This is an updated and expanded series of patches cleaning up some
> stuff
> related to the sound channels. The first three were included in the
> first patch
> series and have only minor changes from Frediano's review. The 4th
> patch from
> the first series ("remname 'connection' to 'client'") was removed
> and replaced
> with the 6th patch in this series.
> 
> Jonathon Jongsma (6):
>   sound: Remove on_new_playback_channel_client()
>   sound: Remove on_new_record_channel_client()
>   sound: Remove dead code in client constructors
>   sound: use GList for global list of sound channels
>   sound: Change snd_playback_start/snd_record_start
>   sound: don't store client in SndChannel
> 
>  server/sound.c | 179 +++++++++++++++++++++++++---------------------
> -----------
>  1 file changed, 77 insertions(+), 102 deletions(-)
>