[Spice-devel] [PATCH v3] sound: Remove dead code in client constructors

[Christophe Fergeau]

On Tue, Apr 25, 2017 at 10:57:34AM -0500, Jonathon Jongsma wrote:
> When a new PlaybackChannelClient or RecordChannelClient is created,
> there are several places where we make decisions based on whether the
> client is active or not. But these checks are done before the 'active'
> flag is ever set, so this code is effectively dead. This has been the
> case since commit 6fdcb9310d8bd0383af97951ff7ba270c5ba08be and
> d351bb35ce981d39e839528f4a23bc5b501adab8, so this code has not been
> executed for approximately 7 years now.
> 
> Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
> ---
> 
> Here's the patch with an updated commit log mentioning the commits that caused
> the code to become dead.

I'd shorten the hashes (you usually only need about 8 chars), apart from
this, still ack from me.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170428/5adf51c1/attachment.sig>