[Spice-devel] [PATCH 1/3] Add check for macOS, disable ucontext on macOS (deprecated)

[Christophe de Dinechin]

> On 28 Apr 2017, at 13:57, Daniel P. Berrange <berrange at redhat.com> wrote:
> 
> On Fri, Apr 28, 2017 at 07:48:01AM -0400, Marc-André Lureau wrote:
>> Hi
>> 
>> ----- Original Message -----
>>> Subject: [PATCH 1/3] Add check for macOS, disable ucontext on macOS
>>> (deprecated)
>>> 
>> 
>> It's also deprecated on Linux afaik, but it's still the preferred way in qemu too.
>> 
>> An alternative would be to implement sigaltstack I suppose (available in qemu).
> 
> Until any OS actually remove ucontext, IMHO it is better to stick
> with the ucontext impl as it is tried & tested and known to have
> good performance. I certainly wouldn't recommend use of the
> gthread impl as its performance is going to be worse & has very
> little testing. 

macOS has zero testing right now anyway. But I can test the ucontext version instead and report.

Christophe

> 
> Regards,
> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|