[Spice-devel] [PATCH 2/3] Fix unsatisfied symbol from export list if USE_USBREDIR is not set

[Christophe Fergeau]

Please add a more descriptive commit log, which symbols are missing,
what tries to use it, or the error log for the compilation, ...
Fairly sure this can be figured out from the diff and the code, but
I try to be as descriptive as possible in the commit log, nicer to read
this than dig in the code ;)

Christophe


On Fri, Apr 28, 2017 at 01:41:01PM +0200, Christophe de Dinechin wrote:
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  src/usb-device-manager.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
> index 6e6a683..66f0eb5 100644
> --- a/src/usb-device-manager.c
> +++ b/src/usb-device-manager.c
> @@ -786,6 +786,7 @@ static gboolean spice_usb_device_manager_get_device_descriptor(
>      return TRUE;
>  }
>  
> +#endif // USE_USBREDIR
>  
>  /**
>   * spice_usb_device_get_libusb_device:
> @@ -812,6 +813,7 @@ spice_usb_device_get_libusb_device(const SpiceUsbDevice *device G_GNUC_UNUSED)
>      return NULL;
>  }
>  
> +#ifdef USE_USBREDIR
>  static gboolean spice_usb_device_manager_get_libdev_vid_pid(
>      libusb_device *libdev, int *vid, int *pid)
>  {
> @@ -1117,7 +1119,7 @@ static int spice_usb_device_manager_hotplug_cb(libusb_context       *ctx,
>      g_idle_add(spice_usb_device_manager_hotplug_idle_cb, args);
>      return 0;
>  }
> -#endif
> +#endif // USE_USBREDIR
>  
>  static void spice_usb_device_manager_channel_connect_cb(
>      GObject *gobject, GAsyncResult *channel_res, gpointer user_data)
> -- 
> 2.11.0 (Apple Git-81)
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170428/0aafba07/attachment.sig>