[Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

Frediano Ziglio fziglio at redhat.com
Tue Aug 1 11:51:37 UTC 2017


> 
> Hey,
> 
> On Thu, Jul 27, 2017 at 11:08:06AM -0400, Frediano Ziglio wrote:
> > Try to sum up the initial problem was patches/series tracking
> > 
> > 2) similar to patchwork with additional feature but missing
> >    the state tracking part. Maybe would be not hard to add;
> > 
> > Maybe would be worth speaking with patchew author if
> > is easy doable and agree with the change.
> 
> I got in touch last week (before your email), and patchew will indeed
> not detect when a patch series has been pushed to git, but he told me
> this would be a nice feature to have, so he is not against adding that.
> However, one thing I realized during the discussion is that the main
> goal of patchew is to apply the series to git master, run tests against
> it, and send an email if something went wrong. The web interface is just
> an addition on top of this.
> It can track reviewed/non-reviewed/obsolete series though, provided we
> consistently use Reviewed-by tags.
> 
> Christophe
> 

Yes, looks like one big target is CI. However is also able to track,
as you said, reviewed and other statuses. Adding another status does
not look that complicated; I'm actually trying to understand how it
works and adding another status is not complicated, more on how to use
it.
About the "consistently use Reviewed-by" this is already been proved
to be not possible in our team. We use patchwork but we can't say we
use consistently these replies, lot of the times they came in different
format.

Frediano


More information about the Spice-devel mailing list