[Spice-devel] [PATCH spice-gtk 0/2] Disabling mmtime adjustment in the client (from audio backend)

[Marc-André Lureau]

Hi

----- Original Message -----
> From: Victor Toso <me at victortoso.com>
> 
> There should be some effort to make spice-server adjust mmtime correctly
> instead
> of relying on audio backend output directly.
> 
> The latency from audio backend should be forwarded to spice-server but that's
> yet to be implemented.
> 
> This two patches allow us to simply turn-off adjusting mmtime in the client
> directly from audio's backend.
> 
> A property sounds reasoanble as this might be something nice to test even if
> mmtime from spice-server looks great, for instance, considering a mocked data
> from server we can compare if mmtime from server is better then spice-gtk
> adjustments based on pulseaudio input.

This really looks like test code to me.

Is this really something we want to have checked in? and in the API?

If it's generally useful tweak, I would rather use an environment variable, but I doubt this is the case.

I start to be worried about all of our streaming tweaks and issues. Is there any effort to use RTP/SRTP instead? I think this would be a big opportunity to improve the situation going forward.


> Cheers,
>     toso
> 
> Victor Toso (2):
>   session: introduce "video-sync-on-audio-latency" property
>   spicy: toggle SpiceSession::video-sync-on-audio-latency
> 
>  src/channel-playback.c   |  7 ++++++-
>  src/spice-session-priv.h |  1 +
>  src/spice-session.c      | 33 +++++++++++++++++++++++++++++++++
>  tools/spicy.c            | 43 ++++++++++++++++++++++++++++++++++++++++++-
>  4 files changed, 82 insertions(+), 2 deletions(-)
> 
> --
> 2.13.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>