[Spice-devel] [spice-common v2 08/13] quic: s/decorrelate_drow/correlate_row

[Christophe Fergeau]

On Wed, Aug 02, 2017 at 05:10:56AM -0400, Frediano Ziglio wrote:
> > 
> > The naming is odd as this is just an alias for channel->correlate_row.
> > This will also help in subsequent commits to make things more
> > consistent with quic_rgb_tmpl.c
> > 
> > Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> 
> This IMHO should go as 1/13 and is more related to previous series.


The patch by itself is not really correct as in
-        decorrelate_drow[0] = family.xlatU2L[cur_row->a];

xsalU2L[] is initialized by decorrelate_init(), so decorrelate_row is
not a bad name. Imo this patch only makes sense in the context of
unifying quic_tmpl.c and quic_rgb_tmpl.c, so I would not move it out of
the series.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170803/a78e5ff3/attachment.sig>