[Spice-devel] [PATCH spice-gtk 0/2] Disabling mmtime adjustment in the client (from audio backend)

[Marc-André Lureau]

Hi

----- Original Message -----
> > I start to be worried about all of our streaming tweaks and issues. Is
> > there any effort to use RTP/SRTP instead? I think this would be a big
> > opportunity to improve the situation going forward.
> 
> There is not effort on that AFAIK.
> 

I would put my effort there.

> But I'm interested on improving the mmtime in server side but it'll be
> hard if I can't disable this long-term workaround.
> 
> If it isn't a workaround, I would like to understand why.
> 
>   commit fbe3b5ec32e3d93f0a0f41239b85be723d8d91c5
>   Author: Marc-André Lureau <marcandre.lureau at redhat.com>
>   Date:   Wed Dec 22 15:32:45 2010 +0100
> 
>       gtk: update mm time based on playback time+delay
> 

This is not a workaround, iirc.

The way I remember it, video frames have ts, based on audio time (or supposed to I think server implementation is lacking there). 

When we receive audio packets, we are supposed to set the current mmtime. We asked the audio backend what is the current audio delay, and update mmtime = last_packet.time - audio_delay, so we can sync the video frames on audio.

Wrong? Yeah probably, video streaming is not an easy subject, that's why effort should be put on using the real thing that gstreamer can provide us (almost) for free.

> Cheers,
>     toso
> >
> > 
> > > Cheers,
> > >     toso
> > > 
> > > Victor Toso (2):
> > >   session: introduce "video-sync-on-audio-latency" property
> > >   spicy: toggle SpiceSession::video-sync-on-audio-latency
> > > 
> > >  src/channel-playback.c   |  7 ++++++-
> > >  src/spice-session-priv.h |  1 +
> > >  src/spice-session.c      | 33 +++++++++++++++++++++++++++++++++
> > >  tools/spicy.c            | 43
> > >  ++++++++++++++++++++++++++++++++++++++++++-
> > >  4 files changed, 82 insertions(+), 2 deletions(-)
> > > 
> > > --
> > > 2.13.0
> > > 
> > > _______________________________________________
> > > Spice-devel mailing list
> > > Spice-devel at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> > > 
>