[Spice-devel] Getting patchwork to acknowledge acks?

[Christophe de Dinechin]

> On 4 Aug 2017, at 14:49, Victor Toso <victortoso at redhat.com> wrote:
> 
> On Fri, Aug 04, 2017 at 02:34:44PM +0200, Christophe de Dinechin wrote:
>> 
>>> On 4 Aug 2017, at 14:03, Frediano Ziglio <fziglio at redhat.com> wrote:
>>> 
>>>> 
>>>> Hi,
>>>> 
>>>> On Fri, Aug 04, 2017 at 01:01:05PM +0200, Christophe de Dinechin wrote:
>>>>>> It does not check if given patch was pushed, no. :(
>>>>> 
>>>>> If so, that’s a lot less useful than PRs.
>>>> 
>>>> All comes down to workflow in the end... Some people love it :)
>>>> https://patchwork.linuxtv.org/
>>>> 
>>> 
>>> The missing synchronization with git was discussed already on
>>> our ML thread, both patchew and patchwork share this missing
>>> feature.
>> 
>> I love the phrasing “share this missing feature” ;-)
>> 
>>> 
>>> Not saying that patchwork have few interesting feature, indeed.
>>> Just don't have this. Mostly patchew add CI feature (as far as
>>> I saw). Just today I was wondering why this CI feature was
>>> not implemented on top of patchwork instead of having another
>>> tool.
>> 
>> I wonder if patchwork is not supposed to have at least some testing
>> capabilities. There is a “Test” menu on https://patchwork.freedesktop.org/project/Spice/series.
> 
> For..  Tested-by: Victor Toso <victortoso at redhat.com>
> :)

Oh, I see. Manual CI it is then ;-) <shrug/>

How does it know about the “pass/fail/info/warning”?

> 
>> Anyway, let me answer the question about the “Done” state.
>> Apparently, you can only change the state for a patch *you* submitted.
>> So the “state” button for the patch I referred to earlier does not show up,
>> presumably because only Pavel can change it.
> 
> I think anyone from Spice group in freedesktop can, manually, change it.

Ah, I may have made the mistake of creating another account on patchwork.
So I guess I’m supposed to reuse my freedesktop account?

> 
>> If I look at a patch I sent, then I have a button and also a “delegate to” pop up.
>> One of the choices is pw-git-hook. What does that mean?
>> 
>> Thanks
>> Christophe
> 
> pw is a command line tool, you could apply a series with something like
> git pw apply-series 3837 (series-id)
> 
> Not sure about pw-git-hook.

If you don’t know, who knows?…


Thanks
Christophe

>