[Spice-devel] [PATCH spice-gtk] build-sys: stop installing spicy

[Pavel Grunt]

Hi,

do you want to keep installing spicy-screenshot and spicy-stats? They are
also tools just for testing.

Pavel

2017-08-10 11:37 GMT+02:00 Marc-André Lureau <marcandre.lureau at redhat.com>:

> Hi
>
> ----- Original Message -----
> > Hi,
> >
> > On Wed, Aug 09, 2017 at 10:48:58PM +0200, marcandre.lureau at redhat.com
> wrote:
> > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > >
> > > spicy is only a test UI. A proper end-user UI is provided by
> > > virt-viewer, vinagre or Boxes for example.
> > >
> > > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > I don't see why a testing tool should not be installed...
>
> Because users expect it to be a fully-featured client, which is not. Imho,
> as a testing tool, it's fine to have it only in the build directory. You
> may install it manually, but it shouldn't be there by default.
>
> We may want to have --enable-installed-tests, that would be a different
> patch though
> https://wiki.gnome.org/Initiatives/GnomeGoals/InstalledTests
>
> >
> > > ---
> > >  tools/Makefile.am | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/Makefile.am b/tools/Makefile.am
> > > index 7c2d90e..5b7c4de 100644
> > > --- a/tools/Makefile.am
> > > +++ b/tools/Makefile.am
> > > @@ -13,7 +13,7 @@ TOOLS_CPPFLAGS =                  \
> > >     $(NULL)
> > >
> > >  if WITH_GTK
> > > -bin_PROGRAMS += spicy
> > > +noinst_PROGRAMS = spicy
> > >  TOOLS_CPPFLAGS += $(GTK_CFLAGS)
> > >  endif
> > >
> > > --
> > > 2.14.0.1.geff633fa0
> > >
> > > _______________________________________________
> > > Spice-devel mailing list
> > > Spice-devel at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> >
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170810/40481682/attachment.html>