[Spice-devel] [PATCH spice-gtk] Remove wocky HTTP proxy

[Victor Toso]

Hi,

On Thu, Aug 10, 2017 at 10:31:58AM +0000, Marc-André Lureau wrote:
> On Thu, Aug 3, 2017 at 3:19 PM Marc-André Lureau <
> marcandre.lureau at redhat.com> wrote:
> 
> > Hi
> >
> > ----- Original Message -----
> > > On Thu, Aug 03, 2017 at 01:12:10PM +0100, marcandre.lureau at redhat.com
> > wrote:
> > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > >
> > > > That HTTP proxy code has been added to glib 2.43.92.
> > >
> > > Does this mean the HTTP proxy code was already unused when running
> > > with a recent glib? Or was wocky-http always used, and after this commit
> > > we will switch to the glib implementation?
> >
> > GLib implementation is based on spice-gtk implementation, so both are
> > quite similar.
> >
> > GIO implementation should be first registered
> > (_g_io_modules_ensure_loaded), they have same priority 0. There might be
> > other GIO modules with http/https proxy as higher priority, though unlikely.
> >
> > g_io_extension_point_get_extension_by_name() used by gproxy takes the list
> > in order, and the list is updated with g_list_insert_sorted(), so Spice
> > implementation is returned first so far. This will effectively replace it
> > with glib version if no other http/https extension exists on the system.
> >
> 
> ack? (it should be non-controversial, it replaces our implementation with
> one that is better maintained and that was based on our implementation)
> -- 
> Marc-André Lureau

Yes, should be fine.
Acked-by: Victor Toso <victortoso at redhat.com>

> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170810/e76f89cf/attachment.sig>