[Spice-devel] [PATCH spice-server v2] Remove call to red_channel_client_push outside RedChannel

[Frediano Ziglio]

Now the push is done automatically when a PipeItem is added
(cfr commit 5c460de1a3972b7cf2b9b2944d0b500c3affc363
"worker: push data when clients can receive them"),
forcing a push cause only network fragmentation and is required
only if you are handling data in a loop instead of using the
default loop.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Victor Toso <victortoso at redhat.com>
---
 server/dcc.c | 2 --
 1 file changed, 2 deletions(-)

Changes since v1:
- update commit message.

diff --git a/server/dcc.c b/server/dcc.c
index a9529fae..4490507b 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -399,7 +399,6 @@ void dcc_push_surface_image(DisplayChannelClient *dcc, int surface_id)
     /* not allowing lossy compression because probably, especially if it is a primary surface,
        it combines both "picture-like" areas with areas that are more "artificial"*/
     dcc_add_surface_area_image(dcc, surface_id, &area, NULL, FALSE);
-    red_channel_client_push(RED_CHANNEL_CLIENT(dcc));
 }
 
 static void add_drawable_surface_images(DisplayChannelClient *dcc, Drawable *drawable)
@@ -679,7 +678,6 @@ void dcc_push_monitors_config(DisplayChannelClient *dcc)
     mci = red_monitors_config_item_new(red_channel_client_get_channel(RED_CHANNEL_CLIENT(dcc)),
                                        monitors_config);
     red_channel_client_pipe_add(RED_CHANNEL_CLIENT(dcc), &mci->pipe_item);
-    red_channel_client_push(RED_CHANNEL_CLIENT(dcc));
 }
 
 static RedSurfaceDestroyItem *red_surface_destroy_item_new(RedChannel *channel,
-- 
2.13.5