[Spice-devel] [PATCH spice-server v2] gstreamer: Check if ORC library can work

[Christophe Fergeau]

On Fri, Aug 25, 2017 at 11:30:29AM -0400, Frediano Ziglio wrote:
> > 
> > On Fri, Aug 25, 2017 at 10:33:28AM -0400, Frediano Ziglio wrote:
> > > > 
> > > > On Fri, Aug 18, 2017 at 12:32:12PM +0100, Frediano Ziglio wrote:
> > > > > ORC lirabry is used internally by GStreamer to generate code
> > > > > dynamically.
> > > > 
> > > > "The ORC library"
> > > > 
> > > > > If ORC cannot allocate executable memory the failure cause
> > > > > an abort(3) to be called.
> > > > 
> > > > "memory, the failure causes"
> > > > 
> > > > > This happens on some SELinux configuration that disable executable
> > > > > memory allocation (execmem boolean).
> > > > 
> > > > Either "SELinux configurations" or "that disables"
> > > > 
> > > > > Check that ORC could work before attempting to use GStreamer to
> > > > > avoid crashes. The log will report an error.
> > > > 
> 
> Maybe I should extend the "The log will report an error." with a
> 
> "While this check is done ORC library output an error which
> will be well visible in Qemu output."

"is done, the ORC library outputs ..."
Looks good yes,

Christophe