[Spice-devel] [PATCH spice-server] stream: Remove unused display parameter

Victor Toso victortoso at redhat.com
Fri Dec 1 14:46:07 UTC 2017


Hi,

On Fri, Dec 01, 2017 at 02:33:19PM +0000, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Seems that was never used
Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  server/video-stream.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/server/video-stream.c b/server/video-stream.c
> index 65da3f8a..619e5ed3 100644
> --- a/server/video-stream.c
> +++ b/server/video-stream.c
> @@ -218,8 +218,7 @@ static void update_copy_graduality(DisplayChannel *display, Drawable *drawable)
>      }
>  }
>  
> -static bool is_next_stream_frame(DisplayChannel *display,
> -                                 const Drawable *candidate,
> +static bool is_next_stream_frame(const Drawable *candidate,
>                                   const int other_src_width,
>                                   const int other_src_height,
>                                   const SpiceRect *other_dest,
> @@ -474,8 +473,7 @@ void video_stream_trace_update(DisplayChannel *display, Drawable *drawable)
>  
>      FOREACH_STREAMS(display, item) {
>          VideoStream *stream = SPICE_CONTAINEROF(item, VideoStream, link);
> -        bool is_next_frame = is_next_stream_frame(display,
> -                                                  drawable,
> +        bool is_next_frame = is_next_stream_frame(drawable,
>                                                    stream->width,
>                                                    stream->height,
>                                                    &stream->dest_area,
> @@ -496,7 +494,7 @@ void video_stream_trace_update(DisplayChannel *display, Drawable *drawable)
>      trace = display->priv->items_trace;
>      trace_end = trace + NUM_TRACE_ITEMS;
>      for (; trace < trace_end; trace++) {
> -        if (is_next_stream_frame(display, drawable, trace->width, trace->height,
> +        if (is_next_stream_frame(drawable, trace->width, trace->height,
>                                   &trace->dest_area, trace->time, NULL, FALSE)) {
>              if (video_stream_add_frame(display, drawable,
>                                         trace->first_frame_time,
> @@ -521,7 +519,7 @@ void video_stream_maintenance(DisplayChannel *display,
>      if (prev->stream) {
>          VideoStream *stream = prev->stream;
>  
> -        is_next_frame = is_next_stream_frame(display, candidate,
> +        is_next_frame = is_next_stream_frame(candidate,
>                                               stream->width, stream->height,
>                                               &stream->dest_area, stream->last_time,
>                                               stream, TRUE);
> @@ -535,7 +533,7 @@ void video_stream_maintenance(DisplayChannel *display,
>          SpiceRect* prev_src = &prev->red_drawable->u.copy.src_area;
>  
>          is_next_frame =
> -            is_next_stream_frame(display, candidate, prev_src->right - prev_src->left,
> +            is_next_stream_frame(candidate, prev_src->right - prev_src->left,
>                                   prev_src->bottom - prev_src->top,
>                                   &prev->red_drawable->bbox, prev->creation_time,
>                                   prev->stream,
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171201/be45010d/attachment.sig>


More information about the Spice-devel mailing list