[Spice-devel] [PATCH spice-common] codegen: Define identity macros for enum types

[Victor Toso]

Hi,

On Thu, Nov 16, 2017 at 01:24:01PM +0100, Christophe Fergeau wrote:
> On Thu, Nov 16, 2017 at 07:12:17AM -0500, Frediano Ziglio wrote:
> > > 
> > > Hey,
> > > 
> > > Some concrete examples of what you are going to do with it would be
> > > useful ;)
> > > 
> > > Christophe
> > > 
> > > On Mon, Nov 13, 2017 at 01:16:32PM +0000, Frediano Ziglio wrote:
> > > > An identity macro in C is a macro defined as
> > > > 
> > > >   #define SOME_NAME SOME_NAME
> > > > 
> > > > They are often used to make possible to use preprocessor to check
> > > > for values existence like
> > > > 
> > > >   #ifdef SOME_NAME
> > > >   ... use SOME_NAME ...
> > > >   #endif
> > 
> > This IMO is a concrete example. A more concrete would be another
> > commit but looks weird putting a hash to a not merged commit.
> > Or should I inline the commit here?
> 
> I would replace this with some real names, and some real code (or at
> a sentence describing something in SPICE context).
> 
> Christophe

I second that. If you have a patch with this in the ML using this, can
you reference it here at least?

Cheers,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171201/9d8ec8ea/attachment-0001.sig>