[Spice-devel] [PATCH spice-server] Reduce dependencies from red-qxl.h

[Jonathon Jongsma]

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Wed, 2017-11-22 at 11:05 +0000, Frediano Ziglio wrote:
> This header is mainly exporting functions to handle public
> interface for the QXL devices.
> Avoid spreading its inclusion including this header in other
> headers.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/dcc-send.c        | 1 +
>  server/display-channel.c | 1 +
>  server/display-channel.h | 1 -
>  server/red-worker.c      | 1 +
>  server/red-worker.h      | 1 -
>  5 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/server/dcc-send.c b/server/dcc-send.c
> index 84c10968..59993c10 100644
> --- a/server/dcc-send.c
> +++ b/server/dcc-send.c
> @@ -24,6 +24,7 @@
>  
>  #include "dcc-private.h"
>  #include "display-channel-private.h"
> +#include "red-qxl.h"
>  
>  typedef enum {
>      FILL_BITS_TYPE_INVALID,
> diff --git a/server/display-channel.c b/server/display-channel.c
> index ad346c93..345b133d 100644
> --- a/server/display-channel.c
> +++ b/server/display-channel.c
> @@ -22,6 +22,7 @@
>  
>  #include "display-channel-private.h"
>  #include "glib-compat.h"
> +#include "red-qxl.h"
>  
>  G_DEFINE_TYPE(DisplayChannel, display_channel,
> TYPE_COMMON_GRAPHICS_CHANNEL)
>  
> diff --git a/server/display-channel.h b/server/display-channel.h
> index 5e3d9eb7..73a06feb 100644
> --- a/server/display-channel.h
> +++ b/server/display-channel.h
> @@ -32,7 +32,6 @@
>  #include "red-record-qxl.h"
>  #include "demarshallers.h"
>  #include "red-channel.h"
> -#include "red-qxl.h"
>  #include "dispatcher.h"
>  #include "main-channel.h"
>  #include "migration-protocol.h"
> diff --git a/server/red-worker.c b/server/red-worker.c
> index fa57235d..046c723e 100644
> --- a/server/red-worker.c
> +++ b/server/red-worker.c
> @@ -44,6 +44,7 @@
>  
>  #include "spice.h"
>  #include "red-worker.h"
> +#include "red-qxl.h"
>  #include "cursor-channel.h"
>  #include "tree.h"
>  
> diff --git a/server/red-worker.h b/server/red-worker.h
> index 3c447f12..68c5058d 100644
> --- a/server/red-worker.h
> +++ b/server/red-worker.h
> @@ -24,7 +24,6 @@
>  #ifndef RED_WORKER_H_
>  #define RED_WORKER_H_
>  
> -#include "red-qxl.h"
>  #include "red-channel.h"
>  
>  typedef struct AsyncCommand AsyncCommand;