[Spice-devel] [PATCH vdagent v3 2/3] retrieve _NET_WM_NAME using GDK

[Victor Toso]

Hi,

On Fri, Dec 01, 2017 at 05:32:18PM +0100, Jakub Janků wrote:
> On Fri, 2017-12-01 at 17:11 +0100, Victor Toso wrote:
> > Tried again, both:
> > 
> > Current (master) vdagent:
> > * XFCE: Xfwm4
> > * MATE: Metacity (Marco)
> > * GNOME x11: GNOME Shell
> > * GNOME wayland: GNOME Shell
> > 
> > With yours:
> > * XFCE: Xfwm4
> > * MATE: Metacity (Marco)
> > * GNOME x11: GNOME Shell
> > * GNOME wayland: GNOME Shell
> > 
> > So, not sure what I did wrong in the previous test. This time I
> > rebooted
> > the VM entirely, I'm not sure that I did that the first time.
> > 
> > As long as we keep some log (next patch) I think this should be fine
> > 
> 
> Great! However, since Mate returns "Metacity (Marco)", the
> vdagent_x11_has_icons_on_desktop() will return FALSE. I don't know
> whether this used to be just "Marco", but maybe it would be reasonable
> to check if _NET_WM_NAME contains one of the names from
> wms_with_icons_on_desktop array (instead of looking for exact match)?

I'm not really sure where does this string come from tbh. Based in this
simple test, looking for a substring instead might make sense but I
think it might be better (and simpler) to just add another element to
the string array containing "Metacity (Marco)", keeping "Marco" for
possibly older versions of MATE.

Arg, might be better to understand who sets this strings and why did it
change.. but that's outside of this patch.

Cheers,
        toso
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171204/c3b8caea/attachment.sig>