[Spice-devel] [PATCH vdagent v4 3/4] refetch _NET_WM_NAME in vdagent_x11_has_icons_on_desktop()

[Victor Toso]

On Wed, Dec 06, 2017 at 04:18:25PM +0100, Victor Toso wrote:
> > > --- a/src/vdagent/x11.c
> > > +++ b/src/vdagent/x11.c
> > > @@ -228,18 +228,18 @@ struct vdagent_x11 *vdagent_x11_create(struct
> > > udscs_connection *vdagentd,
> > >      }
> > >      vdagent_x11_send_daemon_guest_xorg_res(x11, 1);
> > >  
> > > -    /* Get net_wm_name, since we are started at the same time as the
> > > wm,
> > > -       sometimes we need to wait a bit for it to show up. */
> > > -    i = 10;
> > > -    x11->net_wm_name = (gchar *)vdagent_x11_get_wm_name();
> > > -    while (!strcmp(x11->net_wm_name, "unknown") && --i > 0) {
> > > +    /* Since we are started at the same time as the wm,
> > > +       sometimes we need to wait a bit for the _NET_WM_NAME to show
> > > up. */
> > > +    const gchar *net_wm_name;
> 
> ... moving this to the top of the block, but I can do both things before
> pushing, no need to send a v5 for this.

Forgot the
Acked-by: Victor Toso <victortoso at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171206/0650dcd1/attachment-0001.sig>