[Spice-devel] [spice-server 1/2] worker: Remove unneeded include

[Frediano Ziglio]

> 
> Nothing seems to be using openssl in red-worker.c
> 

There are direct call to OpenSSL. Search for "SSL_".
But openssl/ssl.h is included in red-stream.h which is
included everywhere :-(

> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
>  server/red-worker.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/server/red-worker.c b/server/red-worker.c
> index 08bfdae29..21622b1e3 100644
> --- a/server/red-worker.c
> +++ b/server/red-worker.c
> @@ -28,7 +28,6 @@
>  #include <unistd.h>
>  #include <poll.h>
>  #include <pthread.h>
> -#include <openssl/ssl.h>
>  #include <inttypes.h>
>  #include <glib.h>
>  

For me is fine but looks like again our policy (not strong)
if we use in some code include directly.

Otherwise,
Acked-by: Frediano Ziglio <fziglio at redhat.com>

I would avoid the include in such a global header just for SSL_CTX
(which is used) but in the other hand I don't like using a "void *"
or a "struct ssl_ctx_st *" which I'm not sure is always defined that
way.

Frediano