[Spice-devel] [PATCH spice-gtk] MainChannel: Fix incorrect deprecations

[Victor Toso]

Hi,

On Thu, Dec 07, 2017 at 03:45:34PM -0600, Jonathon Jongsma wrote:
> Both spice_main_set_display() and spice_main_set_display_enabled() were
> deprecated in favor of the same functions with the spice_main_channel_
> prefix. However, these new functions were never introduced.

Ah, true, weird that I don't get any warnings with this.

> Since these
> functions merely call spice_main_channel_update_display() with a
> constant TRUE argument for the last parameter, this is probably a good
> time to simply drop the _set_display* functions in favor of the
> nearly-identical _update_display* functions (which have one additional
> parameter which determines whether to send the update to the guest).
> 
> Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>

Sure,
Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  src/channel-main.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/channel-main.h b/src/channel-main.h
> index 7650a03..530378d 100644
> --- a/src/channel-main.h
> +++ b/src/channel-main.h
> @@ -111,12 +111,12 @@ void spice_main_clipboard_notify(SpiceMainChannel *channel, guint32 type, const
>  G_DEPRECATED_FOR(spice_main_channel_clipboard_selection_request)
>  void spice_main_clipboard_request(SpiceMainChannel *channel, guint32 type);
>  
> -G_DEPRECATED_FOR(spice_main_channel_set_display)
> +G_DEPRECATED_FOR(spice_main_channel_update_display)
>  void spice_main_set_display(SpiceMainChannel *channel, int id,int x, int y, int width, int height);
>  G_DEPRECATED_FOR(spice_main_update_display)
>  void spice_main_update_display(SpiceMainChannel *channel, int id, int x, int y, int width,
>                                 int height, gboolean update);
> -G_DEPRECATED_FOR(spice_main_channel_set_display_enabled)
> +G_DEPRECATED_FOR(spice_main_channel_update_display_enabled)
>  void spice_main_set_display_enabled(SpiceMainChannel *channel, int id, gboolean enabled);
>  G_DEPRECATED_FOR(spice_main_channel_update_display_enabled)
>  void spice_main_update_display_enabled(SpiceMainChannel *channel, int id, gboolean enabled,
> -- 
> 2.13.6
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171211/67518f90/attachment.sig>