[Spice-devel] [PATCH spice-server v2 03/13] red-stream: Avoid useless copy of mechlist

Frediano Ziglio fziglio at redhat.com
Wed Dec 20 17:00:57 UTC 2017


> 
> On Wed, Dec 20, 2017 at 09:35:00AM +0000, Frediano Ziglio wrote:
> > The list will persist while the SASL connection is not disposed
> > (or another sasl_listmech called).
> > 
> > From documentation:
> >  * results:
> >  *  result    -- NUL terminated result which persists until next
> >  *               call to sasl_listmech for this sasl_conn_t
> 
> I'm afraid I won't have time to review this just now, but this is not
> "From documentation", this is from the .h file. The online
> documentation, the manpage, ... do not mention it, so you have to know
> where to look ;)
> 
> Christophe
> 

Better to remove then, I'll send another version

Frediano


More information about the Spice-devel mailing list