[Spice-devel] [spice-server v1 0/3] misc clang fixes
Victor Toso
victortoso at redhat.com
Thu Dec 21 09:32:51 UTC 2017
From: Victor Toso <me at victortoso.com>
Just playing a bit with clang's warnings. One can build
spice-server with -Wall while removing:
* -Wno-cast-align and -Wno-address-of-packed-member - plenty
warnings yet.
* -Wno-unused-function due GObject's boilerplate
* -Wno-deprecated-declarations due usage of .set_mm_time from
QXLInterface in server/tests/replay.c - harmless. I thought in
wrapping it between G_GNUC_BEGIN/END_IGNORE_DEPRECATIONS macros
but that's only available in glib 2.32 while we require 2.28.
I take that it is easy to forget a -Wno-deprecated-declarations
in server/tests/Makefile.am.
Victor Toso (3):
clang: Don't compute absolute value of unsigneds
clang: Fix possible wrong computation
clang: remove double promotion
server/gstreamer-encoder.c | 7 ++++++-
server/red-record-qxl.c | 2 +-
server/red-replay-qxl.c | 2 +-
server/tests/test-display-resolution-changes.c | 4 ++--
4 files changed, 10 insertions(+), 5 deletions(-)
--
2.15.1
More information about the Spice-devel
mailing list