[Spice-devel] [spice-server v1 3/3] clang: remove double promotion
Frediano Ziglio
fziglio at redhat.com
Thu Dec 21 14:35:41 UTC 2017
>
> From: Victor Toso <me at victortoso.com>
>
> > test-display-resolution-changes.c:55:60: error: implicit conversion
> > increases floating-point precision: 'float' to 'double'
> > command->create_primary.width = 800 + sin((float)count / 6) * 200;
> > ~~~ ~~~~~~~~~~~~~^~~
> > test-display-resolution-changes.c:56:61: error: implicit conversion
> > increases floating-point precision: 'float' to 'double'
> > command->create_primary.height = 600 + cos((float)count / 6) * 200;
> > ~~~ ~~~~~~~~~~~~~^~~
>
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
> server/tests/test-display-resolution-changes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/tests/test-display-resolution-changes.c
> b/server/tests/test-display-resolution-changes.c
> index f6bb0839..74e71a7d 100644
> --- a/server/tests/test-display-resolution-changes.c
> +++ b/server/tests/test-display-resolution-changes.c
> @@ -52,8 +52,8 @@ set_primary_params(SPICE_GNUC_UNUSED Test *test, Command
> *command)
> #endif
> static int count = 0;
>
> - command->create_primary.width = 800 + sin((float)count / 6) * 200;
> - command->create_primary.height = 600 + cos((float)count / 6) * 200;
> + command->create_primary.width = 800 + sin(count / 6.0) * 200;
> + command->create_primary.height = 600 + cos(count / 6.0) * 200;
> count++;
> }
>
Acked-by: Frediano Ziglio <fziglio at redhat.com>
Frediano
More information about the Spice-devel
mailing list