[Spice-devel] [PATCH spice-common] canvas-base: Fix width computation for palette images

[Phil Turmel]

On Thu Dec 21, 2017 at 17:52:48 +0000, Christophe Fergeau wrote:
> On Thu, Dec 21, 2017 at 03:59:27PM +0000, Frediano Ziglio wrote:
>> Palette images are encoded with a slightly larger pixel than
> 
> "slightly larger pixel" ? Is it missing a word ?
> 
>> width. This cause a wrong calculation of stride_encoded value
>> which cause a wrong stride adjustment.
> 
> "causes" (*2)
> 
> So this was changed in 5603961ff "fix 16 bpp LZ image decompression".
> Before that commit, the stride was computed as
> stride = (n_comp_pixels / height) * 4;
> This commit was added to spice-gtk in v0.32~58, which nicely matches the
> "client regression when upgrading from spice-gtk v0.31 to spice-gtk
> v0.33"
> 
> I'd mention some of these in the commit log, but apart from this,
> 
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Christophe

I can confirm that this fixes my gentoo system via local patch, as
originally reported in bug #1416580 and follow-up bug #1508847.

Tested-by: Philip J. Turmel <philip at turmel.org>

Regards,

Phil