[Spice-devel] [PATCH spice-server v3 02/12] red-stream: Avoid infinite loop on sasl_encode/decode failure

[Snir Sheriber]

Hi


On 12/22/2017 12:07 PM, Frediano Ziglio wrote:
> These functions do not set errno so is possible that errno is EAGAIN.

s/is possible/it is possible/

> This would cause an infinite loop in functions like
> red_stream_write_all (or potentially using the event loop).
>
> Signed-off-by: Frediano Ziglio<fziglio at redhat.com>
> ---
>   server/red-stream.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/server/red-stream.c b/server/red-stream.c
> index f4637808c..3dbdfca82 100644
> --- a/server/red-stream.c
> +++ b/server/red-stream.c
> @@ -596,6 +596,7 @@ static ssize_t red_stream_sasl_write(RedStream *s, const void *buf, size_t nbyte
>                             &s->priv->sasl.encodedLength);
>           if (err != SASL_OK) {
>               spice_warning("sasl_encode error: %d", err);
> +            errno = EIO;
>               return -1;
>           }
>   
> @@ -657,6 +658,7 @@ static ssize_t red_stream_sasl_read(RedStream *s, uint8_t *buf, size_t nbyte)
>                         &decoded, &decodedlen);
>       if (err != SASL_OK) {
>           spice_warning("sasl_decode error: %d", err);
> +        errno = EIO;
>           return -1;
>       }
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171231/3efcfc3f/attachment.html>