[Spice-devel] [spice-server v6 7/9] reds: drop sscanf() in favour of g_strsplit()

[Christophe Fergeau]

On Wed, Feb 01, 2017 at 01:39:26PM +0100, Victor Toso wrote:
> Hi,
> 
> On Tue, Jan 31, 2017 at 03:54:01PM +0100, Christophe Fergeau wrote:
> > On Tue, Jan 31, 2017 at 07:16:04AM -0500, Frediano Ziglio wrote:
> > > >
> > > > From: Victor Toso <me at victortoso.com>
> > > >
> > > > As there is a need to iterate over every encoder:codec pair and we
> > > > do a check for every encoder and every codec, g_strsplit() is less
> > > > complex and easier to follow.
> > > >
> > > > This change makes much easier to extend the input which is
> > > > currently a list of tuples encoder:video-codec.
> > > >
> > > > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > >
> > > I had a though this morning about the syntax.
> > >
> > > We are moving from a set or "encoder:codec" separated with ";" to a
> > > set of "encoder:codec:priority". All this to allow same priority in
> > > the list. Why not having a "light" separator, something like
> > >
> > > "gstreamer:vp8 gstreamer:h264;gstreamer:h264;spice:mjpeg"
> > >
> > > (not the space). So the first 2 will have same "priority" while the
> > > others less (but different) ?
> >
> > Do we need to have an extra-smart string-based syntax like this? Or
> > can we side-step this problem by having a higher-level API?
> 
> Indeed, if it gets too complex, an extra API would be better.
> If we agree in having an extra API, we can drop this patch but
> suggestions for the API are welcome :)

My plan was all along to figure out the API while adding support for
this in QEMU/libvirt, but I never got to it. So no idea :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170202/a0d3741f/attachment.sig>