[Spice-devel] [PATCH spice-server 1/2] stat-file: Fix off by one buffer overflow

Frediano Ziglio fziglio at redhat.com
Fri Feb 3 09:56:01 UTC 2017


> 
> On Thu, 2017-02-02 at 10:52 -0600, Jonathon Jongsma wrote:
> > Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
> > 
> > Out of curiosity, how did you find it? Just reading code?
> 
> Nevermind. I see that the next patch is addressing a compiler warning
> in this code, so you were obviously looking closely at this code for
> that reason.
> 
> 

Yes and not.
As said in a previous mail one check in the code was duplicated
so I removed it but turns out that this caused the buffer
overflow to be triggered by the test (test-stat-file) which
was failing as the file was allocating 11 elements out of 10.

Frediano


More information about the Spice-devel mailing list