[Spice-devel] [spice-gtk v1 0/4] spice-channel read/flush wire functions

[Victor Toso]

Hi,

On Fri, Feb 03, 2017 at 03:39:42PM +0100, Pavel Grunt wrote:
> Hi,
> 
> it follows the spice style [0], so it is an improvement.
> I am not happy with commit messages ("small rework").
> Also you should add a reference to the bug you are solving (it is
> somehow related).
> 
> btw g_assert_nonnull is not available in the glib we require

Wow, 2.40 !!! I never realized it. I'll change and improve the commit
log, thanks for the review.


> 
> Pavel
> 
> [0] https://www.spice-space.org/spice-project-coding-style-and-coding-
> conventions.html#_short_functions
> 
> On Fri, 2017-02-03 at 15:24 +0100, Victor Toso wrote:
> > From: Victor Toso <me at victortoso.com>
> > 
> > Hi,
> > 
> > I'm working on basic QoS integration in the client, to avoid some
> > channels to use all the bandwidth and I end up touching this part of
> > the code.
> > 
> > I tried to make the code a little bit more straight forward to
> > understand. Let me know if these changes make sense to you.
> > 
> > Cheers,
> > 
> > Victor Toso (4):
> >   spice-channel: move out non blocking logic of _read_wire()
> >   spice-channel: small rework on spice_channel_read_wire()
> >   spice-channel: move out non blocking logic of _flush_wire()
> >   spice-channel: small rework on spice_channel_flush_wire()
> > 
> >  src/spice-channel.c | 174 +++++++++++++++++++++++++++++++++------
> > -------------
> >  1 file changed, 112 insertions(+), 62 deletions(-)
> > 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170203/c00d4b3c/attachment.sig>