[Spice-devel] [spice-gtk v6 0/9] Add preferred video codec type message (Jan 31)

[Pavel Grunt]

Hi,

imo the patches for improving the label in spicy can be postponed. 

Usually the new property "stream-video-codec-type" will not change, so
I am not sure if it is useful, otoh there is currently no other way
for getting the info you want.

Pavel

On Tue, 2017-01-31 at 12:08 +0100, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> Hi!
> 
> Patchset rebased with some requested changes. The 09/09 is the RFC
> regarding priority per video-codec in the server, considering
> host/client preferences.
> 
> Changes are in my gitlab, stream-preference branch
> -> https://gitlab.com/victortoso/spice-gtk
> -> https://gitlab.com/victortoso/spice
> 
> Changes in this version:
> - (Pavel) New `middle way` function called
>   spice_display_send_client_preferred_video_codecs between the
> external
>   API spice_display_change_preferred_video_codec_type() as the later
>   only requests a single video-codec value from application but we
> send
>   an array to the server.
> 
> - (Pavel) Disable in spicy, the video-codecs that are missing due
>   channel capabilities
> 
> - New property in channel-display called stream-video-codec-type, so
> we
>   can notify which video-codec we are using while streaming.
> - A new value in spicy' status label to display the video-codec used
> in
>   the streaming, or none if no streaming is ongoing.
> 
> Not using git publish/series yet... hopefuly my notes are in order!
> 
> * spice-gtk
> Victor Toso (6):
>   Update spice-common
>   channel-display: implement preferred video codec msgc
>   spicy: implement preferred video codec type
>   channel-display: new stream-video-codec-type property
>   spicy: keep status of mouse/agent on server mode
>   spicy: improve status label with stream information
> 
>  configure.ac                         |   2 +-
>  doc/reference/spice-gtk-sections.txt |   1 +
>  spice-common                         |   2 +-
>  src/channel-display.c                |  81
> +++++++++++++++++++++++++
>  src/channel-display.h                |   1 +
>  src/map-file                         |   1 +
>  src/spice-glib-sym-file              |   1 +
>  tools/spicy.c                        | 114
> ++++++++++++++++++++++++++++++++---
>  8 files changed, 194 insertions(+), 9 deletions(-)
> 
> * spice-server
> Victor Toso (3):
>   reds: drop sscanf() in favour of g_strsplit()
>   dcc: handle preferred video codec message
>   (RFC) reds: add support to priority for video codecs
> 
>  server/dcc-private.h               |   5 ++
>  server/dcc.c                       | 122
> +++++++++++++++++++++++++++++++++++++
>  server/dcc.h                       |   1 +
>  server/display-channel.c           |   2 +
>  server/reds.c                      |  70 +++++++++++----------
>  server/stream.c                    |   5 +-
>  server/tests/test-codecs-parsing.c |  13 ++--
>  server/video-encoder.h             |   1 +
>  8 files changed, 183 insertions(+), 36 deletions(-)
>